search

Automattic / nginx-http-concat

WordPress plugin to perform CSS and JavaScript concatenation of individual script files into one resource request.
GNU General Public License v2.0
115 stars 32 forks source link

SVG inside CSS can be inadvertently altered by concat code #24

Closed nickdaugherty closed 7 years ago

nickdaugherty commented 7 years ago

The CSS handler strips whitespace, but that can cause issues on SVG data (such as in background-url properties) where whitespace is significant. Need to more carefully strip spaces in these situations.

https://github.com/Automattic/nginx-http-concat/blob/2ebbdd88217d0578eddb6e3d332eb25c6d8581c7/cssmin.php#L468

Related: https://github.com/tubalmartin/YUI-CSS-compressor-PHP-port/pull/27/commits/715d4d1ffb368735f1188efe6c4547555b7b65b9

joshbetz commented 7 years ago

Should be fixed by https://github.com/Automattic/nginx-http-concat/commit/d15f982dcc91da37f0cda6b4553992eb9b82c594

nickdaugherty commented 7 years ago

Ah thanks, closing.