Closed justinshreve closed 7 years ago
Sweet, looks and works great 👍 I tested by just changing a <Gridicons>
icons
prop to cart
.
Thanks for the reviews!
@kwight Just wondering, what is the process for getting changes deployed? Does Lannister handle that? I'm not in a huge rush (I still have some work to do on the .com side) but I wasn't sure if there was anything I needed to do to push it live.
@justinshreve We've just started implementing a two-week rotating schedule for releases (p3fqKv-5V6-p2); I can cut a new beta today, giving us two weeks until production release Nov 8th. Of course, if that doesn't work, just let me know and we'll certainly work something out!
@kwight That should work perfectly I think. Thank you!
This PR adds the
cart
icon to the noticon to gridicon transformation list, making it possible to use thecart
icon for notifications.We will be using this for a new order notification for Store on WP.com.
To Test:
notifications-panel
per the README.public-api
.class-notification-builders-v1-1.php
and find the builder for one of the notifications in your stream. For example,build_post_reply
for a comment reply.set_noticon
call to$builder->set_noticon( 'cart' );
http://notifications.dev:8888/
) and view.