It would be great to fully transition to Gridicons away from Noticons. Notifs were built around noticons at the time (we even have a set_noticon() method server-side), and we've been hacking in gridicons by swapping noticons for the corresponding gridicon in /src/utils/noticon2gridicon.js.
246 brought up that there's no clean way to just add a gridicon if it doesn't have an existing noticon, so let's just transition away fully from the whole noticon-swap dance.
I could see it going like this:
[ ] Add a method server-side to duplicate set_noticon(), that handles only gridicons without any of the noticon plumbing.
[ ] Move over existing gridicons to use the new method.
[ ] Replace any last remaining noticons with gridicons.
It would be great to fully transition to Gridicons away from Noticons. Notifs were built around noticons at the time (we even have a
set_noticon()
method server-side), and we've been hacking in gridicons by swapping noticons for the corresponding gridicon in/src/utils/noticon2gridicon.js
.246 brought up that there's no clean way to just add a gridicon if it doesn't have an existing noticon, so let's just transition away fully from the whole noticon-swap dance.
I could see it going like this:
set_noticon()
, that handles only gridicons without any of the noticon plumbing.