Automattic / notifications-panel

Core notifications panel for WordPress.com notifications
0 stars 1 forks source link

Replace noticons with Gridicons. #259

Open kwight opened 6 years ago

kwight commented 6 years ago

It would be great to fully transition to Gridicons away from Noticons. Notifs were built around noticons at the time (we even have a set_noticon() method server-side), and we've been hacking in gridicons by swapping noticons for the corresponding gridicon in /src/utils/noticon2gridicon.js.

246 brought up that there's no clean way to just add a gridicon if it doesn't have an existing noticon, so let's just transition away fully from the whole noticon-swap dance.

I could see it going like this: