search

Automattic / notifications-panel

Core notifications panel for WordPress.com notifications
0 stars 1 forks source link

Giant Emojis #275

Closed justinshreve closed 6 years ago

justinshreve commented 6 years ago

This is probably one of the funniest bugs I've come across, but I have a post where the emojis are coming through massive in the notifications panel.

screen shot 2018-05-25 at 12 16 40 pm

The post in question is p90Yrv-GY-p2.

dmsnell commented 6 years ago

this is probably because these images are SVGs without inherent size values.

in #196 I added a CSS rule to set the max-width to 100% and without an inherent width it looks like the browser is scaling SVGs all the way.

not sure what the fix is as we don't know how big these should be. maybe we need to hit this from the server and try to parse SVG attributes if we want to get it right - or make some dumb rule like "SVGs are small" and limit them to a max width in pixels… neither solution is good.

dmsnell commented 6 years ago

I take it back - in the post in question we had an emoji class on the image tag…maybe we can fix this easier and "well enough"

kwight commented 6 years ago

I think the "bug" is that @justinshreve doesn't ❤️ emojis enough.

dmsnell commented 6 years ago

Should have been resolved in r176030-wpcpm - @justinshreve would you mind looking at that notification again to confirm?

justinshreve commented 6 years ago

Confirmed the issue is resolved! Thank you!