search

Automattic / notifications-panel

Core notifications panel for WordPress.com notifications
0 stars 1 forks source link

Packages: Update to Webpack 3. #276

Closed kwight closed 6 years ago

kwight commented 6 years ago

This PR updates the repo to Webpack 3. webpack-dev-server also gets bumped to 2.11.2.

Testing

  1. Blow away node-modules and package-lock.json, then do a fresh npm install.
  2. Smoke test as much of the app as possible; there should be no related errors or regressions.
  3. There should be no references to the hoek package in package-lock.json.
kwight commented 6 years ago

@dmsnell I think this should take care of it now.

kwight commented 6 years ago

if you regenerated the package-lock.json file from scratch then :shipit:

Yep; tested by confirming the changes worked fine, then blew away both node_modules and package-lock.json, then did a fresh install and verified again. Thanks for the review!