Automattic / page-optimize

WordPress plugin to optimize pages for faster load and render in the browser
GNU General Public License v2.0
32 stars 11 forks source link

Page Optimize: Plugin Behavior when Jetpack Boost is active #79

Open hacchism opened 8 months ago

hacchism commented 8 months ago

Quick summary

When Page Optimize is active while Jetpack Boost is also active, the link "Optimize JS and CSS for faster page load and render in the browser" in Jetpack → Settings → Performance → Performance & speed directs a user to https://example.com/wp-admin/admin.php?page=page-optimize, but the plugin setting page is blocked with the error "Sorry, you are not allowed to access this page.".

Screen Shot on 2024-03-09 at 15:37:27

Screen Shot on 2024-03-09 at 15:37:35

Steps to reproduce

  1. Make sure that both Page Optimize and Jetpack Boost are active.
  2. Visit Jetpack → Settings → Performance → Performance & speed.
  3. Click on the link "Optimize JS and CSS for faster page load and render in the browser.

What you expected to happen

The link directs a user to the plugin setting for Jetpack Boost - https://example.com/wp-admin/admin.php?page=jetpack-boost

What actually happened

The link directs a user to the plugin setting for Page Optimize, and the page is blocked due to some sort of restriction.

I understand that we are blocking access to the plugin setting for Page Optimize when Jetpack Boost is also active because both basically do the same thing, but this is pretty confusing.

I'd suggest connecting the link to the plugin setting for Jetpack Boost instead as the link is within the Jetpack setting. It would also be helpful to display a nudge on the Jetpack Boost plugin setting page recommending disabling Page Optimize when both plugins are active.

Impact

Some (< 50%)

Available workarounds?

No but the platform is still usable

Logs or notes

No response

rickmgithub commented 8 months ago

📌 REPRODUCTION RESULTS

Tested on Atomic (not relevant to simple site) – Replicated

📌 FINDINGS/SCREENSHOTS/VIDEO

Recreated exactly as OP describes It's not a serious issue as it has no functional effect by the look of it but it is a broken link.

📌 ACTIONS

Triaged

hacchism commented 4 months ago

Another report on 8476342-zen

github-actions[bot] commented 4 months ago

Support References

This comment is automatically generated. Please do not edit it.