search

Automattic / php-push

Work-in-progress on Push Notifications v2
5 stars 1 forks source link

Add tests for APNSResponse unrecoverable error #19

Closed mokagio closed 4 years ago

mokagio commented 4 years ago

Just warming up while I try to add tests for the cURL behavior.

jkmassel commented 4 years ago

FYI – I had to rebase this on main because the codeclimate checks are required, and wouldn't run until that was done!

codeclimate[bot] commented 4 years ago

Code Climate has analyzed commit 0b8f81a4 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 80.7% (0.5% change).

View more on Code Climate.

mokagio commented 4 years ago

@jkmassel

I noticed “squash and merge” is the only option for the repo now. Or maybe it always was and I never notice.

I’m fine with that 👍 , although it’s not my favorite option because it may result in big commits, which are then harder to look at in isolation from the log. It'll be fun to work in a different way than I'm used to, use different muscles.

Just curious to know your rationale. I thought it might have to do with moving things over to the other repo, but then realized we use the raw code from a tag for that 🤔 .

jkmassel commented 4 years ago

Oh – should be able to use "Rebase and Commit" as well, which doesn't squash, but just moves inline. I find early in a project, if we need to go back and rewrite some history or something, it's way easier to do if we don't have a huge number of merge commits all over the place :P