search

Automattic / php-push

Work-in-progress on Push Notifications v2
5 stars 1 forks source link

Add examples folder to list of folders to lint and fix issues #28

Closed mokagio closed 4 years ago

mokagio commented 4 years ago

Most of the changes were made by phpcbf.

I'm not sure about the change from date to gmdate, the rationale provided by PHPCS was:

date() is affected by runtime timezone changes which can cause date/time to be incorrectly displayed. Use gmdate() instead.

I suppose it's a safe change to make, given this is only an example file anyways.

I decided to disable the warnings on global functions and function name not using snake casing for the same reason as above, this is an example file.

codeclimate[bot] commented 4 years ago

Code Climate has analyzed commit d3971491 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 80.7% (0.0% change).

View more on Code Climate.

mokagio commented 4 years ago

This is good, though I had a work-in-progress PR on this.

I thought that might be the case, but it didn't take long to work on this and I learnt quite a few interesting things.

From what I can see, #30 supersedes this, so it might be easier to close this one instead?

mokagio commented 4 years ago

Closing in favor of #30.