search

Automattic / phpcs-neutron-standard

A set of phpcs sniffs for PHP >7 development
MIT License
94 stars 7 forks source link

Update dev dependencies to latest versions #79

Closed yoavf closed 4 years ago

yoavf commented 4 years ago

Currently, when running $ ./vendor/bin/phpunit after a clean composer install, the following errors are reported.

1) NeutronStandardTest\DisallowLongformArraySniffTest::testDisallowLongformArraySniff
"continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"?

/dev/phpcs-neutron-standard/vendor/squizlabs/php_codesniffer/src/Tokenizers/Tokenizer.php:746
/dev/phpcs-neutron-standard/vendor/squizlabs/php_codesniffer/autoload.php:167
/dev/phpcs-neutron-standard/vendor/squizlabs/php_codesniffer/autoload.php:167
/dev/phpcs-neutron-standard/vendor/squizlabs/php_codesniffer/autoload.php:134
/dev/phpcs-neutron-standard/vendor/squizlabs/php_codesniffer/src/Tokenizers/PHP.php:14
/dev/phpcs-neutron-standard/vendor/squizlabs/php_codesniffer/autoload.php:167
/dev/phpcs-neutron-standard/vendor/squizlabs/php_codesniffer/autoload.php:134
/dev/phpcs-neutron-standard/vendor/squizlabs/php_codesniffer/src/Sniffs/AbstractPatternSniff.php:917
/dev/phpcs-neutron-standard/vendor/squizlabs/php_codesniffer/src/Sniffs/AbstractPatternSniff.php:825
/dev/phpcs-neutron-standard/vendor/squizlabs/php_codesniffer/src/Sniffs/AbstractPatternSniff.php:90
/dev/phpcs-neutron-standard/vendor/squizlabs/php_codesniffer/src/Ruleset.php:1197
/dev/phpcs-neutron-standard/vendor/squizlabs/php_codesniffer/src/Ruleset.php:218
/dev/phpcs-neutron-standard/tests/SniffTestHelper.php:13
/dev/phpcs-neutron-standard/tests/Sniffs/Arrays/DisallowLongformArraySniffTest.php:14

2) NeutronStandardTest\DisallowLongformArraySniffTest::testFixDisallowLongFormArraySniff
"continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"?

/dev/phpcs-neutron-standard/vendor/squizlabs/php_codesniffer/src/Files/File.php:1404
/dev/phpcs-neutron-standard/vendor/squizlabs/php_codesniffer/autoload.php:167
/dev/phpcs-neutron-standard/vendor/squizlabs/php_codesniffer/autoload.php:167
/dev/phpcs-neutron-standard/vendor/squizlabs/php_codesniffer/autoload.php:134
/dev/phpcs-neutron-standard/vendor/squizlabs/php_codesniffer/src/Files/LocalFile.php:16
/dev/phpcs-neutron-standard/vendor/squizlabs/php_codesniffer/autoload.php:167
/dev/phpcs-neutron-standard/vendor/squizlabs/php_codesniffer/autoload.php:134
/dev/phpcs-neutron-standard/tests/SniffTestHelper.php:22
/dev/phpcs-neutron-standard/tests/Sniffs/Arrays/DisallowLongformArraySniffTest.php:26

These errors are from phpcs. Updating all of our dev deps to their latest versions fixes this error, and the tests will pass with no errors.

Testing:

sirbrillig commented 4 years ago

🤔 This fails the CI tests because the updated version of phpunit requires PHP 7.2 or greater and this library currently supports PHP 7.0. What version of PHP were you seeing those errors on? (If it's 7.3, it may mean that we need to add 7.3 to the CI build targets as well as 7.0, 7.1, and 7.2.)