search

Automattic / phpcs-neutron-standard

A set of phpcs sniffs for PHP >7 development
MIT License
94 stars 7 forks source link

Support for PHP 8? #85

Closed gmazzap closed 3 years ago

gmazzap commented 3 years ago

Right now, your composer.json says "php": "^7.0"

I'm trying to run tests for PHP 8 in some of my libraries, but that requirems make composer install fails. Can you maybe change to >=7.0?

sirbrillig commented 3 years ago

That's a good question. I haven't had a chance to test these rules on PHP 8; can you confirm they work there? I seem to recall reading that PHPCS doesn't yet support PHP 8...

sirbrillig commented 3 years ago

If it's helpful at all, and it may not be, I deal with similar issues (in my case running tests on PHP 5.x) by having different composer.json files for different PHP environments and have my CI configured to use the appropriate one. This isn't a full solution, because it really just means that I don't use the linters that are unavailable on those environments, but it does let you skip them to run other tests.

sirbrillig commented 3 years ago

Should be fixed by https://github.com/Automattic/phpcs-neutron-standard/pull/86