Automattic / pocket-casts-android

Pocket Casts Android 🎧
https://forums.pocketcasts.com
Mozilla Public License 2.0
2.59k stars 225 forks source link

Bookmark Episode Sort doesn't sort by Timestamp #1741

Open aurarora opened 10 months ago

aurarora commented 10 months ago

Description

When sorting bookmarks on the Podcast page by "Episode", I expect the bookmarks from a single Episode to be sorted by the Timestamp within that Episode. This is not the case, they get sorted by creation date.

Step-by-step reproduction instructions

  1. Create multiple bookmarks within single Episode, preferably creating ones later in the Episode first.
  2. Go to Podcast page
  3. Go to Bookmarks tab
  4. Sort by "Episode"
  5. Notice that bookmark within a single episode get sorted by creation time, not Timestamp within Episode

Screenshots or screen recording

No response

Did you search for existing bug reports?

Device, Operating system, and Pocket Casts app version

No response

MiSikora commented 10 months ago

Can confirm. iOS handles it this way, and it makes sense to sort it this way.

aurarora commented 10 months ago

I don't know whether this is planned, but I personally would also like the option to both sort by "Episodes oldest to newest" and "Episodes newest to oldest". Not sure about the naming of those though.

MiSikora commented 10 months ago

I'll add that to our internal feature improvements list for bookmarks.

MiSikora commented 9 months ago

From my testing today while working on syncing this doesn't have 100% reproduction rate. It can happen that the app will get into a state where Episode sorting doesn't account for the timestamp.

aurarora commented 9 months ago

@MiSikora

From my testing today while working on syncing this doesn't have 100% reproduction rate. It can happen that the app will get into a state where Episode sorting doesn't account for the timestamp.

Huh, you're right. Just tested again and when opening the app it was sorting it by the creation date, but after changing it from and then to 'Episodes', it started sorting correctly.

Another issue though I've been having with bookmarks, is that the timestamps don't always line up correctly with the bookmarks after changing the sorting. Not sure whether I should open another issue in this.

MiSikora commented 9 months ago

Not sure whether I should open another issue in this.

Yes, please do. 🙏