search

Automattic / pocket-casts-android

Pocket Casts Android šŸŽ§
https://forums.pocketcasts.com
Mozilla Public License 2.0
2.57k stars 219 forks source link

The Details panel is not consistent #1860

Open vivadavid opened 8 months ago

vivadavid commented 8 months ago

Description

The Details panel provides different information depending on whether you access to it through the list of episodes of a podcast or through the playback of the episode.

Step-by-step reproduction instructions

  1. You go to a podcast, scroll down until you find an episode you like and tap on it.
  2. You click on Play to listen to the episode.
  3. The panel is automatically minimized.
  4. You tap to maximize it again.
  5. Now the Details panel contains different information. My main problem is that I can't find an icon to download the episode.

It's happened to me a couple of times: I start listening to an episode from a podcast and, at some point, I want to download it, but I can't unless I go back to the list of episodes of the podcast and find the specific episode I'm currently listening to.

The Details panel should always stay the same. If there's some information that needs to be displayed only when the episode is being played, you could either combine all the information or just create a new panel.

Screenshots or screen recording

The Details panel when accessed through the list of episodes:

details_panel_1

The Details panel when the episode is being played:

details_panel_2

(For some reason, there's light mode in one screen and dark mode in the other one, but the screen modes on my phone don't always work well.)

Did you search for existing bug reports?

Device, Operating system, and Pocket Casts app version

Xiaomi mi 9T Pro, Android 11, Pocket Casts 7.57 (9193).

MiSikora commented 8 months ago

Can you clarify for me what is the core issue? Is it different design of the screens or is it the fact that you can't download episodes from the player's view? For example, would having a download action in the Now playing section of the player solve your problem?

vivadavid commented 8 months ago

Hi,

I certainly value consistency: I don't understand how the same panel can look so different. In fact, it seems like a different panel despite the name.

Having said that, my main problem is the absence of a download button. It's happened to me a few times that I was listening to a podcast, I needed to download it and I was unable to do it unless I found again the episode on the list of the podcast.

The insertion of a download button would be extremely useful and time-saving.

MiSikora commented 8 months ago

The difference is there because part of the Details tab in the episode is in the Now Playing tab of the player. Those are two different contexts for consuming content.

cc: @david-gonzalez-a8c if you can weigh in on the design issue described here.

The insertion of a download button would be extremely useful and time-saving.

I think the most reasonable solution without changing the design is to have download action as an option in the shelf items.

Added it as an internal feature request. Internal ref: pdjfGa-Ia-p2

david-gonzalez-a8c commented 8 months ago

The refactoring of the episode and player views so they are more consistent (which I agree would be a good thing) would take a bigger design effort. In the meantime, I don't see a reason why we shouldn't add a "Download" action in the player "More actions" sheet.

I've prepared some quick specs here where you can grab the icon from. I suggest we add it before "Archive" on the list.

vivadavid commented 3 months ago

Hi,

On version 7.67, I've added the Download button:

IMG_20240709_131104

And yet the Download button doesn't appear anywhere on the bottom when I'm listening to my podcast:

IMG_20240709_131146

MiSikora commented 3 months ago

@vivadavid Thanks for the follow-up. I reported it here #2477

vivadavid commented 2 months ago

Hi,

I know that there are other issues to look into and I don't want to seem pushy, but it's been a while since the feature to download a podcast while you're listening to it was implemented and then removed. As nothing is mentioned in the changelog for version 7.70, I was wondering if there are plans to implement it again.

Thanks!

CookieyedCodes commented 2 months ago

@mebarbosa why was it removed again?

MiSikora commented 2 months ago

@vivadavid I can download an episode while listening to it. Can you create a separate bug report for it?

@CookieyedCodes What do you mean by again? Was it removed at some point in the past?

vivadavid commented 2 months ago

@MiSikora , when I'm listening to an episode, I don't have a download button available at hand to download it. I have to go back to the podcast and find the episode.

MiSikora commented 2 months ago

Ah, yes. I didn't understand it at first. It is in our backlog as an open issue but we don't have immediate plans to implement it.

vivadavid commented 2 months ago

Ah, yes. I didn't understand it at first. It is in our backlog as an open issue but we don't have immediate plans to implement it.

Thanks! I keep my fingers crossed!

CookieyedCodes commented 2 months ago

Ya I think it was removed because it was taking up 3 spaces in the overflow menu or something like that (download, downloading & remove download)

Hopefully someday :)

MiSikora commented 2 months ago

Yes, it was due to this issue https://github.com/Automattic/pocket-casts-android/issues/2477

CookieyedCodes commented 2 months ago

Ah that's it šŸ˜‰