Automattic / pocket-casts-android

Pocket Casts Android 🎧
Mozilla Public License 2.0
2.53k stars 209 forks source link

Display playback progress during clip sharing #2417

Closed MiSikora closed 1 day ago

MiSikora commented 4 days ago

Description

This PR adds playback progress to clip sharing. Playback progress is draggable. There are also some changes to the behavior.

Note: Zooming is acting junky when timeline is not scrolled to the beginning. I plan to work on it in the future.

Testing Instructions

  1. Start sharing.
  2. Drag progress to some position.
  3. Play the clip.
  4. Playback should start from the dragged position.
  5. Let the clip playback to the end.
  6. Play the clip again.
  7. Playback should start.
  8. Pause playback.
  9. Playback should stop.
  10. Resume playback.
  11. Playback should start from the paused position.
  12. While clip is playing drag end or start of the clip.
  13. Playback should stop.
  14. Resume playback.
  15. Playback should start from the beginning.

Screenshots or Screencast

https://github.com/Automattic/pocket-casts-android/assets/30936061/20a73f2d-d12b-452e-aa12-798030bd9434

Checklist

I have tested any UI changes...

dangermattic commented 4 days ago
2 Warnings
:warning: This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
:warning: Class ShareClipViewModelListener is missing tests, but unit-tests-exemption label was set to ignore this.

Generated by :no_entry_sign: Danger

CookieyedCodes commented 4 days ago

Ummmmm would it be possible to have a download clip function and speed control for those downloads

MiSikora commented 4 days ago

This isn't something that we're currently planning for the feature.

CookieyedCodes commented 4 days ago

Fair enough, I get why but ye can understand why I would love both tbh 😅