Closed MiSikora closed 1 day ago
2 Warnings | |
---|---|
:warning: | This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews. |
:warning: | Class ShareClipViewModelListener is missing tests, but unit-tests-exemption label was set to ignore this. |
Generated by :no_entry_sign: Danger
Ummmmm would it be possible to have a download clip function and speed control for those downloads
This isn't something that we're currently planning for the feature.
Fair enough, I get why but ye can understand why I would love both tbh 😅
Description
This PR adds playback progress to clip sharing. Playback progress is draggable. There are also some changes to the behavior.
Note: Zooming is acting junky when timeline is not scrolled to the beginning. I plan to work on it in the future.
Testing Instructions
Screenshots or Screencast
https://github.com/Automattic/pocket-casts-android/assets/30936061/20a73f2d-d12b-452e-aa12-798030bd9434
Checklist
./gradlew spotlessApply
to automatically apply formatting/linting)modules/services/localization/src/main/res/values/strings.xml
~I have tested any UI changes...