Transcripts - Integrate (temporary) UI container to show transcript in the Player

ashiagr commented 3 days ago

Description

This displays an episode transcript in the player container's "temporary" Transcripts tab.

Testing Instructions

Launch the app
Play an episode from "Cautionary Tales" (https://pcast.pocketcasts.net/8zpmjiru)
Open player tab
✅ Notice there's a new Transcripts tab
Tap on the Transcripts tab
✅ Notice that the episode's transcript is displayed on the tab (ignore all styling)
Play an episode that does not have a transcript
✅ Notice Transcripts tab is not shown for the episode

Screenshots or Screencast

Checklist

If this is a user-facing change, I have added an entry in CHANGELOG.md - N/A
[x] Ensure the linter passes (./gradlew spotlessApply to automatically apply formatting/linting)
[x] I have considered whether it makes sense to add tests for my changes
[x] All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
Any jetpack compose components I added or changed are covered by compose previews - Not added as views are temporary
I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics. - TBD

I have tested any UI changes...

(N/A as views are temporary)

with different themes
with a landscape orientation
with the device set to have a large display and font size
for accessibility with TalkBack

dangermattic commented 3 days ago

	3 Warnings
:warning:	This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
:warning:	Class `DefaultColors` is missing tests, but `unit-tests-exemption` label was set to ignore this.
:warning:	Class `PodcastAndEpisode` is missing tests, but `unit-tests-exemption` label was set to ignore this.

Generated by :no_entry_sign: Danger

CookieyedCodes commented 3 days ago

Can I give my 2 cents on the UI even at this early stage, I've been finding the top bar a tad crowded since bookmarks have been implemented & especially with chapters it can get a tad unwieldy, my suggestion instead of text, transcripts should be an icon to the left of now playing, that will keep it smaller and keep it from being overwhelming in my opinion 🤔😉🧐

ashiagr commented 3 days ago

I've been finding the top bar a tad crowded since bookmarks have been implemented & especially with chapters it can get a tad unwieldy, my suggestion instead of text, transcripts should be an icon to the left of now playing, that will keep it smaller and keep it from being overwhelming in my opinion

Thanks for the feedback! I cannot yet share the UI but we won't add a new tab for transcripts. It is just a placeholder.

CookieyedCodes commented 3 days ago

Cul cul, thanks for shareing that information, looking forward to seeing it's placement then :)

Automattic / pocket-casts-android