Automattic / pocket-casts-android

Pocket Casts Android 🎧
Mozilla Public License 2.0
2.53k stars 209 forks source link

[Give Rating] Update Rating screen #2438

Closed mebarbosa closed 1 day ago

mebarbosa commented 2 days ago

Description

Fixes #2434 Fixed #2435

Testing Instructions

Make sure GIVE_RATINGS feature flag is enabled

  1. Open a podcast that you did not listen any episode before
  2. Tap on Rate button
  3. ✅ Ensure you see the rating screen with the not allowed to rate messages
  4. Listen any episode from this podcast you are trying to rate until played_up_to is updated
  5. Tap on Rate button
  6. ✅ Ensure you see the rating screen with the option to rate the podcast

Screenshots or Screencast

Screen_recording_20240703_085955.webm

Checklist

I have tested any UI changes...

dangermattic commented 2 days ago
1 Warning
:warning: Class NotAllowedToRate is missing tests, but unit-tests-exemption label was set to ignore this.

Generated by :no_entry_sign: Danger

ashiagr commented 1 day ago

Sorry, I didn't realise that auto-merge was enabled.

mebarbosa commented 1 day ago

Sorry, I didn't realise that auto-merge was enabled.

@ashiagr No worries! I will address this to another PR

mebarbosa commented 1 day ago

@ashiagr I've just put a PR with the changes here https://github.com/Automattic/pocket-casts-android/pull/2445