Automattic / pocket-casts-android

Pocket Casts Android 🎧
https://forums.pocketcasts.com
Mozilla Public License 2.0
2.59k stars 223 forks source link

Add support for system navigation to the low storage dialog #3232

Open geekygecko opened 1 week ago

geekygecko commented 1 week ago

Description

The following issue was found during the beta test. The bottom sheet that appears in the “Storage & data use” and the “Auto download” screens does not respect system navigation and does not react to it.

Internal reference pdeCcb-7BG-p2

Step-by-step reproduction instructions

  1. To easily test, edit the file DeviceStorageUtil.kt and return true from the function isDeviceRunningOnLowStorage.
  2. Go to Profile -> Settings -> Storage & data use
  3. Swipe the side of the screen to go back (or tap the navigation back button)

Notice the page goes back but the dialog remains open. The dialog should close first.

Screenshots or screen recording

https://github.com/user-attachments/assets/d881609c-ec8e-4736-8a5b-df1e5d229cfb

Did you search for existing bug reports?

Device, Operating system, and Pocket Casts app version

Google Pixel 9, Android 14, Pocket Casts 7.77-rc-1