Automattic / pocket-casts-android

Pocket Casts Android 🎧
https://forums.pocketcasts.com
Mozilla Public License 2.0
2.59k stars 223 forks source link

Support edge-to-edge for the whole podcasts section #3245

Closed geekygecko closed 1 day ago

geekygecko commented 3 days ago

Description

This change focuses on all the screens in the podcasts tab. Please ignore the other tabs for now.

One issue I'm struggling to solve at the moment is the bottom sheet navigation bar color. I will have another attempt at fixing it in a future PR.

There will be multiple pull requests required to support Android 15 edge-to-edge but I'm going to break them down into smaller PRs. I will merge them all into a task/android-15 branch, and after all the work is completed, raise a PR to merge into main.

Testing Instructions

It would be good if you could try tapping around in the podcasts tab to find issues with the edge-to-edge changes. Areas I have found issues with are:

Here are some test steps I have followed in case you want to try them too:

  1. Open the podcasts tab
  2. βœ… Verify the next pages aren't under the status bar and you can get to the bottom of the page, even with the mini player open.
  3. Tap on a podcast
  4. Tap on the podcast settings cog
  5. Tap on Auto archive and back
  6. Tap on Playback effects and back
  7. Tap on Filters and go back to the podcasts list
  8. Tap on the search podcasts icon, search for a podcast, and come back to the list
  9. Tap on the three dots, share podcasts, and go through the screens to create a list

Screenshots

Before After
before-podcast-page after-podcast-page
before-podcast-settings-page after-podcast-settings-page
before-podcast-auto-archive-page after-podcast-auto-archive-page
before-podcast-select-filters-page after-podcast-select-filters-page
before-podcast-effects-page after-podcast-effects-page
before-podcast-search after-podcast-search
before-podcast-search-results after-podcast-search-results
before-podcast-share-list after-podcast-share-list
before-podcast-page-landscape after-podcast-page-landscape
before-podcast-list-landscape after-podcast-list-landscape

Checklist

I have tested any UI changes...

wpmobilebot commented 3 days ago
πŸ“² You can test the changes from this Pull Request in πŸ“± Mobile by scanning the QR code below to install the corresponding build.
App Name πŸ“± Mobile
Build TypedebugProd
Commit8bb4f8b7992bb5f3e00f939eeea0a9303d9da714
Direct Downloadpocketcasts-app-prototype-build-pr3245-8bb4f8b.apk
πŸ“² You can test the changes from this Pull Request in πŸš— Automotive by scanning the QR code below to install the corresponding build.
App Name πŸš— Automotive
Build TypedebugProd
Commit8bb4f8b7992bb5f3e00f939eeea0a9303d9da714
Direct Downloadpocketcasts-automotive-prototype-build-pr3245-8bb4f8b.apk
πŸ“² You can test the changes from this Pull Request in ⌚ Wear by scanning the QR code below to install the corresponding build.
App Name ⌚ Wear
Build TypedebugProd
Commit8bb4f8b7992bb5f3e00f939eeea0a9303d9da714
Direct Downloadpocketcasts-wear-prototype-build-pr3245-8bb4f8b.apk
CookieyedCodes commented 2 days ago

@MiSikora seeing that turquoise icon color makes me really want a turquoise theme now πŸ˜…, tho probably implementing custom theming would be easier πŸ€” πŸ€”

MiSikora commented 2 days ago

tho probably implementing custom theming would be easier πŸ€” πŸ€”

No, it definitely wouldn't be easier.

Screenshot 2024-11-20 at 10 36 19

CookieyedCodes commented 2 days ago

XD πŸ˜…

geekygecko commented 2 days ago

The color of empty space in podcast settings changed

@MiSikora thanks for finding that, I have fixed it in https://github.com/Automattic/pocket-casts-android/pull/3245/commits/8bb4f8b7992bb5f3e00f939eeea0a9303d9da714

Before After
Screenshot_20241120_230013 Screenshot_20241120_225926