Automattic / pocket-casts-android

Pocket Casts Android šŸŽ§
https://forums.pocketcasts.com
Mozilla Public License 2.0
2.59k stars 224 forks source link

Profile screen cleanup #3260

Closed MiSikora closed 4 days ago

MiSikora commented 4 days ago

Description

After completing migration this is the last PR that cleans things up:

Testing Instructions

Do monkey testing of the profile screen. Check orientation, theming, tapping on things, different accounts, etc.

Checklist

I have tested any UI changes...

dangermattic commented 4 days ago
1 Warning
:warning: This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by :no_entry_sign: Danger

wpmobilebot commented 4 days ago
šŸ“² You can test the changes from this Pull Request in šŸ“± Mobile by scanning the QR code below to install the corresponding build.
App Name šŸ“± Mobile
Build TypedebugProd
Commitfff54595c247028383bf2b04b0d43044a04e0e13
Direct Downloadpocketcasts-app-prototype-build-pr3260-fff5459.apk
šŸ“² You can test the changes from this Pull Request in šŸš— Automotive by scanning the QR code below to install the corresponding build.
App Name šŸš— Automotive
Build TypedebugProd
Commitfff54595c247028383bf2b04b0d43044a04e0e13
Direct Downloadpocketcasts-automotive-prototype-build-pr3260-fff5459.apk
šŸ“² You can test the changes from this Pull Request in āŒš Wear by scanning the QR code below to install the corresponding build.
App Name āŒš Wear
Build TypedebugProd
Commitfff54595c247028383bf2b04b0d43044a04e0e13
Direct Downloadpocketcasts-wear-prototype-build-pr3260-fff5459.apk
geekygecko commented 4 days ago

This isn't part of this PR but I wanted to suggest some changes to this section. Feel free to ignore these.

changes.patch

Before After
Screenshot_20241122_121335 Screenshot_20241122_122105
MiSikora commented 4 days ago

I applied your patch but had to change theming to make it consistent with the rest of the app in 422540f.