Closed MiSikora closed 4 days ago
1 Warning | |
---|---|
:warning: | This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews. |
Generated by :no_entry_sign: Danger
App Name | š± Mobile | |
Build Type | debugProd | |
Commit | fff54595c247028383bf2b04b0d43044a04e0e13 | |
Direct Download | pocketcasts-app-prototype-build-pr3260-fff5459.apk |
App Name | š Automotive | |
Build Type | debugProd | |
Commit | fff54595c247028383bf2b04b0d43044a04e0e13 | |
Direct Download | pocketcasts-automotive-prototype-build-pr3260-fff5459.apk |
App Name | ā Wear | |
Build Type | debugProd | |
Commit | fff54595c247028383bf2b04b0d43044a04e0e13 | |
Direct Download | pocketcasts-wear-prototype-build-pr3260-fff5459.apk |
This isn't part of this PR but I wanted to suggest some changes to this section. Feel free to ignore these.
Before | After |
---|---|
I applied your patch but had to change theming to make it consistent with the rest of the app in 422540f.
Description
After completing migration this is the last PR that cleans things up:
ProfileFragment
to the view model.Testing Instructions
Do monkey testing of the profile screen. Check orientation, theming, tapping on things, different accounts, etc.
Checklist
./gradlew spotlessApply
to automatically apply formatting/linting)modules/services/localization/src/main/res/values/strings.xml
~I have tested any UI changes...