Automattic / pocket-casts-android

Pocket Casts Android 🎧
Mozilla Public License 2.0
2.56k stars 212 forks source link

Reduce frequency of discover_list_impression tracking #359

Open ashiagr opened 1 year ago

ashiagr commented 1 year ago

discover_list_episode_play event gets fired multiple times when it shouldn't be.

Example 1

This is what happens on tapping the play button on a single episode feature in the discover feed, without any scrolling interaction:

11:08:34.741 πŸ”΅ Tracked: discover_list_episode_play
11:08:34.853 πŸ”΅ Tracked: discover_list_impression
11:08:34.860 πŸ”΅ Tracked: discover_list_impression
11:08:34.885 πŸ”΅ Tracked: discover_list_impression
11:08:34.899 πŸ”΅ Tracked: discover_list_impression
11:08:34.906 πŸ”΅ Tracked: discover_list_impression
11:08:34.911 πŸ”΅ Tracked: discover_list_impression
11:08:34.967 πŸ”΅ Tracked: playback_play, Properties: {"source":"discover",...}

Example 2

After opening up one of the featured podcasts from the discover screen, tapping the subscribe button fires off the following events even though the discover screen isn't visible either before or immediately after tapping the button:

11:13:33.413  πŸ”΅ Tracked: podcast_screen_toggle_summary
11:13:33.418  πŸ”΅ Tracked: podcast_screen_subscribe_tapped
11:13:33.580  πŸ”΅ Tracked: discover_list_impression
11:13:33.586  πŸ”΅ Tracked: discover_list_impression
11:13:33.592  πŸ”΅ Tracked: discover_list_impression
11:13:33.599  πŸ”΅ Tracked: discover_list_impression

Noticed in https://github.com/Automattic/pocket-casts-android/pull/345#discussion_r984697055

Note that

mchowning commented 1 year ago

I just got extra events when I was playing episodes from a podcast that I had added via the discover tab even though I accessed the podcast via the Podcasts tab:

  1. Went to the discover screen
  2. Subscribed to a podcast in the trending list by tapping the plus symbol
  3. Went to the podcast's tab
  4. Tapped on the podcast I just subscribed to
  5. Tapped on the play icon next to one of the episodes
  6. πŸ”΄ Two discover_list_impression events were fired

The same thing happens if I play the episode via a filter.

mchowning commented 1 year ago

I just got extra events when I was just playing episodes from a podcast that I had added via the discover tab even though I accessed the podcast via the Podcasts tab...

I get even more extra events if I scroll a bit on the discover page first. After that, taping play or pause (on any screen, not necessarily on the discover screen) fires off even more discover_list_impression events than if I never visited the discover tab.

mebarbosa commented 2 months ago

@ashiagr Do you think this ticket still make sense? I tried to reproduce it, but I did not face with any weird tracking