Automattic / pocket-casts-android

Pocket Casts Android 🎧
https://forums.pocketcasts.com
Mozilla Public License 2.0
2.56k stars 212 forks source link

Improve Tasker Integration UI #471

Open mchowning opened 1 year ago

mchowning commented 1 year ago

We've recently added integration with Tasker thanks to an open source contribution. 🎉 The UI does not fit with the rest of Pocket Casts though.

Some possible improvements:

Please go ahead and suggest other improvements. These are just a few that immediately came to mind for me.

jacobherrington commented 1 year ago

Hey @mchowning I'm new to mobile dev, pretty sure I could figure this out though. Do you mind if I run with it for a few days?

mchowning commented 1 year ago

That would be great @jacobherrington ! 😄 Let me just ping @joaomgcd in case he had any thoughts here since this is building on top of his work.

joaomgcd commented 1 year ago

Please, go ahead! 😅 I really prefer working on the back-end of stuff, so if you have any good ideas for UI AND can implement them, all the better! Thanks!

mchowning commented 1 year ago

Nope, not done yet 😄

joaomgcd commented 1 year ago

Yeah, I was wondering if you were going to re-open it... 😅

Just a reminder though, the fields can't be number-only fields because Tasker variables can always be used in any field, so they really need to all be string based fields so users can write those variables there.

Thanks again :)

mchowning commented 1 year ago

Just a reminder though, the fields can't be number-only fields because...

👍 I crossed that one off

joaomgcd commented 1 year ago

👍

jacobherrington commented 1 year ago

Haha yes, I got distracted with job hunting - my few days have passed if anyone wants to make more progress. I am not knowledgeable around these things. :)