Open mchowning opened 1 year ago
Hey @mchowning I'm new to mobile dev, pretty sure I could figure this out though. Do you mind if I run with it for a few days?
That would be great @jacobherrington ! 😄 Let me just ping @joaomgcd in case he had any thoughts here since this is building on top of his work.
Please, go ahead! 😅 I really prefer working on the back-end of stuff, so if you have any good ideas for UI AND can implement them, all the better! Thanks!
Nope, not done yet 😄
Yeah, I was wondering if you were going to re-open it... 😅
Just a reminder though, the fields can't be number-only fields because Tasker variables can always be used in any field, so they really need to all be string based fields so users can write those variables there.
Thanks again :)
Just a reminder though, the fields can't be number-only fields because...
👍 I crossed that one off
👍
Haha yes, I got distracted with job hunting - my few days have passed if anyone wants to make more progress. I am not knowledgeable around these things. :)
We've recently added integration with Tasker thanks to an open source contribution. 🎉 The UI does not fit with the rest of Pocket Casts though.
Some possible improvements:
[x] The screen could use some margins around the edge (PR)
[x] It would be nice to use icons to help differentiate the different options. Ideally, the filter options would look very similar to how they look on the filters tab in the app (PR)
[ ] The Dropdown component doesn't indicate whether it can be scrolled to display more items (relevant discussion on StackOverflow). Would be good to find a better way to present the list of options.
[ ] Upon first opening the screen, the user just sees a text box with an icon or two and an ok button. Maybe there is a way we could make the relevant options more obvious to the user? 🤔
[ ] Generally speaking, let's try and update the styling consistent with the rest of Pocket Casts
~Some of the fields accept Strings when only a number is a valid input. It would be great to require the correct input at the UI level. That would also allow us to pass around fewer raw Strings.~ (these have to be strings for Tasker: comment)
Please go ahead and suggest other improvements. These are just a few that immediately came to mind for me.