search

Automattic / pocket-casts-android

Pocket Casts Android 🎧
https://forums.pocketcasts.com
Mozilla Public License 2.0
2.56k stars 213 forks source link

New log in pages do not work well with autofill #697

Open mchowning opened 1 year ago

mchowning commented 1 year ago

Description

In my testing, the new log in and screens never offer to add new credentials to the system password manager. The system password manager does offer to fill in previously saved items for me though (using Google as my password manager).

Step-by-step reproduction instructions

  1. Check your system settings and make sure that "Offer to save passwords" and "Auto sign-in" (or the equivalents on your device) are enabled.
  2. Go to log in with the new onboarding flow
  3. Observe that if you have credentials saved for the app, the system does not always offer to autofill them
  4. Observe that after entering credentials, the system does not offer to save them

Screenshots or screen recording

No response

Did you search for existing bug reports?

Device, Operating system, and Pocket Casts app version

Samsung A13 running Android 12, Pocket Casts 7.30-rc-1

mchowning commented 1 year ago

Sounds like this might be a compose issue: https://issuetracker.google.com/issues/176949051. That issue notes that with non-Google password managers, autofill also isn't working, which I believe @geekygecko has observed.

geekygecko commented 1 year ago

The first login page uses Compose and the second uses the old XML views. Above the keyboard, 1Password gives suggestions only on the second page.

https://user-images.githubusercontent.com/308331/212212121-8cb26725-a523-4d27-92a8-20b9afa5c331.mp4

mchowning commented 1 year ago

I haven't tried it, but it sounds like we may be able to workaround this issue by inserting some regular EditText views inside the composable. If compose doesn't get this fixed soon, that may be worth considering.