search

Automattic / pocket-casts-android

Pocket Casts Android 🎧
https://forums.pocketcasts.com
Mozilla Public License 2.0
2.58k stars 219 forks source link

Enhancement: Add filter criterion for subscription state #715

Open mrwweb opened 1 year ago

mrwweb commented 1 year ago

What problem does this address?

I'm copying the issue from Automattic/pocket-casts-ios#438 opened by @aidano since it's the exact request I have and already has an associated pull request.

I'd like to show, for example, any Downloaded, In Progress episodes irrespective of subscription state.

Proposal: Create a new filter that allows for podcast subscription state to be defined ( All | Subscribed | Not Subscribed)

Since current behavior is that a filter automatically includes only episodes of subscribed podcasts, perhaps the above criterion can default to Subscribed when presented in the UI so that existing filters remain backwards compatible, and are updated only if the user changes the value to include All or Not Subscribed.

This would resolve the unexpected (to me) behavior that a filter showing "Downloads" does not actually include all downloads but only downloads from subscriptions.

What is your proposed solution?

Add a new filter state to account for subscription state so that users can create filters for "All Downloads" instead of just "Downloads from subscribed podcasts".

I would actually be interested even in a filter of "Downloads from Unsubscribed Podcasts" which would also be possible with the proposed change.

Did you search for existing feature suggestions?

CookieyedCodes commented 1 year ago

If someone dose work on filters, I have a few other filter suggestions that I think would greatly enhance the app, agreed this would be nice tho :)

I think Ben (old android dev) when he worked on the app said the reason he was unsure of this type of feature suggestion because All would be every podcast that pockecasts has access to where's the point of filters it to limit lists (possible also it dosen't know what your pods your talking about) so in my view it would be better with a check box under the downloads filter which would be include lose downloads & files?(maby a seperate item)/include non subscribed downloads just my thoughts tho :)

mrwweb commented 1 year ago

because All would be every podcast that pockecasts has access to where's the point of filters it to limit lists

Valid point. To provide focus, the definite primary request here is for there to be a way to see all Downloaded episodes in a filtered view regardless of subscription status.