search

Automattic / pocket-casts-android

Pocket Casts Android 🎧
https://forums.pocketcasts.com
Mozilla Public License 2.0
2.58k stars 223 forks source link

Podcast carousel instantly scrolls after changing screens #852

Closed aurarora closed 1 year ago

aurarora commented 1 year ago

Description

When changing screens (e.g. Profile to Discover) the carousel on the Discover screen scrolls instantly, ignoring any former delay.

Step-by-step reproduction instructions

  1. Launch the app
  2. Go to Discover
  3. Go to other screen (Podcasts, Filters, Profile)
  4. Go to Discover
  5. Notice the carousel scrolls immediately

Screenshots or screen recording

https://user-images.githubusercontent.com/72910336/228772838-d7a6727d-808a-4417-9efa-a806db3bb358.mp4

Did you search for existing bug reports?

Device, Operating system, and Pocket Casts app version

Samsung Galaxy S20 FE 5G wAndroid13, Pocket Casts 7.35-rc-2

ashiagr commented 1 year ago

Thanks for reporting it @b-aaron. 🙏 Raised a PR that adds auto-scroll delay on switching between screens.

aurarora commented 1 year ago

Thanks for reporting it @b-aaron. 🙏 Raised a PR that adds auto-scroll delay on switching between screens.

@ashiagr Just noticed: The same thing happens when opening the app repeatedly. Although not necessarily too bad, it might be a quick fix.

ashiagr commented 1 year ago

@b-aaron 👋

Just noticed: The same thing happens when opening the app repeatedly. Although not necessarily too bad, it might be a quick fix.

I wasn't able to reproduce it in PR https://github.com/Automattic/pocket-casts-android/pull/853. Here's how I see it:

https://user-images.githubusercontent.com/1405144/228840236-ba6c7295-924a-4f6d-930f-1162da287154.mp4

Changes in the PR seem to have fixed this issue as the auto-scroll resuming happens whenever the carousel is re-shown - on changing screens or when the app is resumed. Let me know if you're seeing something different. And thank you once again for flagging it. 🙂

aurarora commented 1 year ago

Changes in the PR seem to have fixed this issue as the auto-scroll resuming happens whenever the carousel is re-shown - on changing screens or when the app is resumed. Let me know if you're seeing something different. And thank you once again for flagging it. 🙂

Great! Thanks for responding!