search

Automattic / pocket-casts-ios

Pocket Casts iOS app 🎧
Mozilla Public License 2.0
1.64k stars 129 forks source link

Discover: Subscribe button is not getting updated in category view #1682

Open mebarbosa opened 4 months ago

mebarbosa commented 4 months ago

Description

The subscribe button does not turn green after subscribing to a podcast, and it doesn't change back when we unsubscribe from a podcast

Step-by-step reproduction instructions

  1. Go to Discover tab
  2. Select a category
  3. Subscribe to a podcast from the podcast filtered list
  4. ❌ See the subscribe button does not update to green
  5. Open this podcast you subscribed and unsubscribe it
  6. Go back to discover
  7. ❌ See the subscribe button does not reflect that you unsubscribed the podcast

Screenshots or screen recording

https://github.com/Automattic/pocket-casts-ios/assets/42220351/0e08de5c-570f-4315-a2f4-d8c839dc6c5e

Did you search for existing bug reports?

Device, Operating system, and Pocket Casts app version

Pocket Casts 7.62.0.3

bjtitus commented 4 months ago

Are we sure the color is supposed to be green when subscribing from the categories screen?. I'm guessing the long list could be updated to green but would like to check with @david-gonzalez-a8c.

The current behavior matches the other long list pages.

See the "Show All" page from the "Popular" Discover cell:

https://github.com/Automattic/pocket-casts-ios/assets/3250/418d4940-5a89-49a5-b623-6c0f2514103f

And also the old Category page (which uses the same code as the current implementation):

https://github.com/Automattic/pocket-casts-ios/assets/3250/6f9a3bc7-7f6c-4abb-8184-2bd38b66e4e9

bjtitus commented 4 months ago

The unsubscribe bug is carried over from the old Category page, so nothing new with the FF. Looking for a fix now.

https://github.com/Automattic/pocket-casts-ios/assets/3250/4341a8da-e653-44a6-a18f-ca368a4e58b9

mebarbosa commented 4 months ago

Thanks for taking a loot at this @bjtitus Let's wait for @david-gonzalez-a8c maybe there is a small parity diff with Android. In Android the subscription button always updates to green

david-gonzalez-a8c commented 4 months ago

It's hard to tell, but my guess is that the icon not turning green in some places is not intentional. Let's make it green in all places and both platforms if that's not too complicated.