Automattic / pocket-casts-ios

Pocket Casts iOS app 🎧
Mozilla Public License 2.0
1.64k stars 129 forks source link

Podcasts page scrolls slightly horizontal #1930

Closed azollafox closed 1 month ago

azollafox commented 1 month ago

Description

When scrolling down in the list of podcasts on the podcast page it is possible to scroll horizontally a bit as well

Step-by-step reproduction instructions

  1. Open Podcast Page
  2. Scroll down and move finger right to left as well

I am able to inconsistently reproduce on my iPhone SE, Pocket Casts 7.67

Screenshots or screen recording

https://d.pr/v/gcawUs

Did you search for existing bug reports?

Device, Operating system, and Pocket Casts app version

Pocket Casts v7.68 Device: iPhone13,3 OS: 17.5.1

leandroalonso commented 1 month ago

cc @SergioEstevao (I believe this was reported before but I couldn't find the issue/thread β€” and if my memory is not failing it was in a small screen device).

Edit: found it.

rviljoen commented 1 month ago

I sporadically see this on iPhone 14 Pro as well:

image

joashrajin commented 1 month ago

+1 at 8516326-zd-a8c

https://github.com/user-attachments/assets/9d2ef8da-2f0a-4d05-9f4e-0c7123c2a75f

rviljoen commented 1 month ago

@SergioEstevao I wonder if this bug may be related to this change: https://github.com/Automattic/pocket-casts-ios/commit/b7a14a6b5b537eb33f100bee4c4617c2cb72d873

When the UI is displayed correctly, then the x inset value is -16: image

When the UI is incorrect, the x inset value is 0: image

SergioEstevao commented 1 month ago

Thanks @rviljoen ! I'm having a look into this today. Should have a Pr out with a fix later today.

rviljoen commented 1 month ago

Hi @SergioEstevao - I tested the code change in https://github.com/Automattic/pocket-casts-ios/pull/1943 and can still reproduce the issue. I can now replicate it consistently by scrolling up/down/left/right quickly, and periodically releasing touch. The left margin disappears upon releasing touch after the rapid scrolls and returns as soon as you touch the screen again (PS - I also saw this behaviour under normal scrolling, but with rapid scrolling I was able to consistently reproduce it, which may be useful for you to find the bug).

https://github.com/user-attachments/assets/b913e9ae-598d-45a2-bcb7-dbc74f8ba6ee

SergioEstevao commented 1 month ago

Thanks for testing it @rviljoen ! I will give it another look.

bikrrr commented 1 month ago

I'm glad this is being looked atβ€”it's been bugging me since the podcast grid update. The issue is most noticeable when there are more rows than can fit on the screen and happens in both 4-column and 3-column grid sizes.

If I start with the grid at the bottom (so the Search box is visible), I just scroll up slightly and the grid will shift left. Here's my repro on an iPhone 15 Pro, iOS 17.6, and Pocket Casts 7.68:

https://github.com/user-attachments/assets/311654ea-64f5-4070-9b04-485f8bc8ff15

rviljoen commented 1 month ago

@bikrrr This was fixed in the latest beta and should make it into the 7.69 public release πŸ‘ŒπŸ»

rviljoen commented 1 month ago

@azollafox This was fixed via https://github.com/Automattic/pocket-casts-ios/pull/1943 and released in v7.69.