Referrals: Integrate api call for get redeem code - Githubissues

Automattic / pocket-casts-ios

Pocket Casts iOS app 🎧

Mozilla Public License 2.0

1.66k stars 133 forks source link

Referrals: Integrate api call for get redeem code #2205

Closed SergioEstevao closed 1 month ago

SergioEstevao commented 1 month ago

📘 Part of: #2083

Fixes #

1	2	3	4

To test

Start the app
Ensure you the Referrals FF enabled and you are using a Plus or Patron account
Go to Profile
Tap on the gift icon on the top left
Tap On Share Guest Pass
See the Share system view
Choose different types of Share and check if they work correctly and show your custom referral URL: https://pocketcasts.com/redeem/XXXXXX
Share and see if you go back to the profile screen.

Checklist

[x] I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
[x] I have considered adding unit tests for my changes.
[x] I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

dangermattic commented 1 month ago

	1 Warning
:warning:	This PR is assigned to the milestone 7.74. This milestone is due in less than 2 days. Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by :no_entry_sign: Danger

SergioEstevao commented 1 month ago

@danielebogo

the card background is white

Fixed here: https://github.com/Automattic/pocket-casts-ios/pull/2205/commits/fd2ce542983dbf93ceca58cb6909f00f99078fbd

The double url on sharing is intentional for now, I will create a separate PR to address it. I will need to set the shared items depending of the Shared to app.