Discover Collection View: Add collection view and view controller cells

Automattic / pocket-casts-ios

Pocket Casts iOS app 🎧

Mozilla Public License 2.0

1.66k stars 133 forks source link

Closed bjtitus closed 1 month ago

bjtitus commented 1 month ago

📘 Part of: #2104

This adds the collection view for Discover.

Categories and regions are not hooked up yet

Enable the discoverCollectionView feature flag
Restart the app
Visit the Discover tab
Verify that everything except for categories and region switching works. Tap on a few podcasts, try subscribing, searching, and scroll around for example.

[x] I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
[x] I have considered adding unit tests for my changes.
[x] I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

dangermattic commented 1 month ago

	3 Warnings
:warning:	View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.
:warning:	This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
:warning:	This PR is assigned to the milestone 7.74 ❄️. The due date for this milestone has already passed. Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by :no_entry_sign: Danger

bjtitus commented 1 month ago

This PR got a bit large but I think I'd rather not break it out any further (say into cells and DiscoverDelegate).

Virtually all of the DiscoverCollectionViewController+DiscoverDelegate is copied directly from DiscoverViewController+DiscoverDelegate.
DiscoverCellType is just an enumerated version of the possible cell types, which we didn't have before. This allows us to iterate through all of them and create separate cell registrations so reuse works correctly.
I'll submit updates for the categories + region switching mostly to keep PR size down

SergioEstevao commented 1 month ago

Version 7.74 has now entered code-freeze, so the milestone of this PR has been updated to 7.75.

danielebogo commented 1 month ago

@bjtitus feel free to change the base branch to release/7.74