search

Automattic / pocket-casts-ios

Pocket Casts iOS app 🎧
Mozilla Public License 2.0
1.65k stars 129 forks source link

Siri Shortcuts: Sound is distorted when resumed or not working #264

Open joashrajin opened 2 years ago

joashrajin commented 2 years ago

Expected behavior

The sound should be clear and resume as it normally does

Actual behavior

When sound is resumed, it sounds like the Volume Boost option is enabled and is very distorted

Steps to reproduce the behavior

https://user-images.githubusercontent.com/16253818/191708059-76f09923-4a1f-473a-b32c-abdb7012143b.MP4

Note: it could be happening with the other shortcuts too

Tested on [iPhone 13], iOS [16], Pocket Casts [7.22.0]
joashrajin commented 2 years ago

Report on Reddit regarding issues resuming podcats using the Siri Shortcuts:

image
thabotswana commented 2 years ago

Reported in 5574648-zen

I’ve reset the phone, I also deleted and reinstalled the app. The shortcut doesn’t appear to work consistently. If I go into the app settings and add the “resume” shortcut, it processes my request, asks me if I want to use pocket casts, and then pulls up the recent ep but doesn’t play it. If I then remove the added shortcut, it might work the first time but not after.

App Version: 7.22 Device: iPhone13,1 OS: 16.0

chipsnyder commented 2 years ago

There might be a few issues happening here:

Distorted Audio

https://github.com/Automattic/pocket-casts-ios/issues/264#issue-1382113255 I haven't been able to recreate this, but I need to listen closely to hear it in the attached video, so I may not be enough of an audiophile to notice the difference.

@leandroalonso suspected that looking at https://github.com/Automattic/pocket-casts-ios/pull/213 might provide clues.

"Something went wrong"

https://github.com/Automattic/pocket-casts-ios/issues/264#issuecomment-1257245633 https://github.com/Automattic/pocket-casts-ios/issues/264#issuecomment-1262449113

I can recreate this regularly by following the Reddit clues 1.) Play a podcast 2.) Make sure the Now Playing Widget is no longer visible on the lock screen

Notice that the shortcut fails but succeeds if the device is unlocked.

EDIT Disabling the passcode also the playback to resume, so this may be a bug in shortcuts or a field we need to opt in to.

I'm going to start by investigating the "Something went wrong"

chipsnyder commented 2 years ago

After enabling the fancy iOS 16 backgrounds, I could no longer reproduce the bug. This may just be a coincidence, though.

One observation, before upgrading the lock screen, Siri would fail. After the change, Siri would ask, "Ready to Resume using Pocket Casts?"

I've searched forums for similar bugs and didn't find anything. Although, I think there is a chance this is an Apple bug.

I'm going to move on to another task but look at this in the background.

chipsnyder commented 2 years ago

Ran into this issue on my way home from the grocery store. This is a quick dump of my observations for when I get back after the weekend.

joashrajin commented 1 year ago

+1 5639378-zd-woothemes