Automattic / pym-shortcode

A WordPress solution to embed iframes that are responsive horizontally and vertically using the NPR Visuals Team's https://blog.apps.npr.org/pym.js/
https://wordpress.org/plugins/pym-shortcode/
GNU General Public License v2.0
14 stars 7 forks source link

Add FAQ point RE graphic asset hosting location #55

Closed eidietrich closed 5 years ago

eidietrich commented 5 years ago

Changes

Added FAQ point addressing where to store graphics (as answered by Ben on Slack after I looked at the doc file and scratched my head for longer than I'm comfortable admitting).

Why

For #

Testing/Questions

Questions that need to be answered before merging:

Steps to test this PR:

benlk commented 5 years ago

This looks good, thank you!

We may want to follow this up with examples at some point, if people have written explainers for where they host their Pym.js graphics. We've referenced dailygrpahics, which uses S3 by default, but I've deployed it via scp to a cheap shared host before, and I'm pretty sure I've seen Brent Jones' work on GitHub in the form of an archive repo somewhere.