Automattic / pym-shortcode

A WordPress solution to embed iframes that are responsive horizontally and vertically using the NPR Visuals Team's https://blog.apps.npr.org/pym.js/
https://wordpress.org/plugins/pym-shortcode/
GNU General Public License v2.0
14 stars 7 forks source link

Wrap the always-visible textControl in a PanelBody so that it has the correct padding #74

Closed benlk closed 4 years ago

benlk commented 4 years ago

Changes

This pull request makes the following changes:

Before:

Screen Shot 2020-03-19 at 19 07 23

After:

Screen Shot 2020-03-19 at 22 18 22

Why

For #72, fixing a visual regression in WP 5.4

Testing/Questions

Features that this PR affects:

Questions that need to be answered before merging:

Steps to test this PR:

  1. View a Pym.js Embeds block's sidebar controls under master, and under this branch.
joshdarby commented 4 years ago

@benlk Do you think we need to update the version number so we don't run into the issue we did when updating SCAIP?

benlk commented 4 years ago

We do need to do that, but I was going to do that in a separate PR.