Old quiz questions can be submitted after quiz is reset, but they aren't graded correctly

[andyadams]

Steps to Reproduce

1. Create a quiz with variable/random questions.
2. Open the quiz in 2 browser tabs.
3. In the 1st tab, complete the quiz questions provided, then reset the quiz. You will have a new set of questions.
4. In the 2nd tab (which has the original questions), complete the quiz.
5. In the 2nd tab, you'll be brought to the quiz results page.

What I Expected

Either:

• The quiz results in the 2nd tab should be graded with the questions submitted in the 2nd tab.
• Or, there should be an error/warning saying that the version of the quiz in the 2nd tab is outdated, and needs to be retaken.

What Happened Instead

The quiz grading does not work correctly: It gives the wrong score for the quiz total, and the incorrect/correct answers are not displayed correctly.

WordPress / Sensei version

4.9.5 / 1.9.20

Browser / OS version

Any

Screenshot / Video

I'm not comfortable posting a video from our site on Github, but I can provide one to an email address.

Context / Source

This was reported by users who were getting odd scores when they submitted quizzes.

After digging into the code, I learned that a user's answers & questions_asked are stored in comment meta.

What is happening is that the questions_asked for a user are changed when the quiz is "reset". However, if the user has a previous version of the quiz open (with different questions), they can still submit those questions, and Sensei has trouble grading because it was expecting the "new" questions.

This is hard to put into words, so let me know if you need more info!

[donnapep]

Additional steps for setting up the quiz:

• Add a few multiple choice questions to the quiz.
• Set Number of questions to show in Quiz Settings to some number that is less than the total number of questions added.
• Select Randomise question order in Quiz Settings.

Ideally, the quiz results in the 2nd tab should be graded with the questions submitted in the 2nd tab.