search

Automattic / sensei

Sensei LMS - Online Courses, Quizzes, & Learning
https://senseilms.com
GNU General Public License v2.0
543 stars 197 forks source link

Hello Theme from Elementor doesn't work with Sensei LMS #5011

Open ctdealba opened 2 years ago

ctdealba commented 2 years ago

Reported in here 4935748 - zen

We are using Elementor and Hello Theme from Elementor like a lot of people out there also in combination with WooCommerce. So I'm really wondering why you are not providing wrappers for the this famous theme until now. I can provide you with the following information I got so far:

  • Hello Theme doesn’t have a check for handling taxonomy templates.
  • Hello Theme doesn't have a page.php file, they are using a index.php instead
  • Hello Theme doesn't have any sidebars registered by default
cena commented 2 years ago

5224582-zen

ctdealba commented 2 years ago

User came back here: forum thread

after the problem came up first time I used Astra Theme and Sensei works fine with it. Unfortunately Astra loads a lot of unneeded code and I would like to switch back to the “blank” Hello Theme from Elementor. I switched theme to test it but the course overview still gives out a “Nothing found” message like long time ago. Just wanted to ask if there’s any update on this. If not, I would really appreciate if you could tell me, why Sensei LMS is not working with Hello Theme and what they would need to add that it works.

They also shared a debug log:

[19-Jul-2022 19:31:52 UTC] PHP Notice:  Trying to get property 'cap' of non-object in /homepages/18/d865945032/htdocs/clickandbuilds/HarmonikaPuls483222/wp-content/plugins/sensei-lms/includes/course-theme/class-sensei-course-theme-option.php on line 230
[19-Jul-2022 19:31:52 UTC] PHP Notice:  Trying to get property 'edit_post' of non-object in /homepages/18/d865945032/htdocs/clickandbuilds/HarmonikaPuls483222/wp-content/plugins/sensei-lms/includes/course-theme/class-sensei-course-theme-option.php on line 230
StefMattana commented 2 years ago

The user on 5569676-zen had issues with the logo replacement; we suggested using Site Editor to edit the Lesson template.

We had the user do the following with no success - the Learning Mode header change didn't showing up in their courses:

  • Go Appearance -> Editor.
  • Choose "Lesson (Learning Mode)" template.
  • Insert an Image block with a new logo in the header, adjust its dimensions and move in the correct position.
  • Remove Site Logo block.
  • Save the template.

but it turns out there is an incompatibility with Hello Elementor.

github-actions[bot] commented 2 years ago

Support References

This comment is automatically generated. Please do not edit it.

StefMattana commented 2 years ago

More different issues reported on 5604620-zen:

I go to load the Course Overview page (where the all courses should be listed for purchase) but I get an error message to say that the page does not exist. I looked through a couple of articles that said I needed to set up a Product Archive page, similar to how I set up my Shop page. But the Course Overview page still does not load; I still get the same error message.

Switching to Twenty Sixteen or Storefront fixes it.

ctdealba commented 2 years ago

Important to note that the Elementor page builder do not support WordPress blocks. In extension, Sensei blocks won't be visible when trying to edit a page using the Elementor edit tool.

danmaze commented 1 year ago

Related report from a user in 6014320-zen using Elementor and the Hello Elementor theme where the lesson content is moving out of the boundaries and overlaying the left sidebar that shows a list of lessons. It happens on horizontal scroll. Screenshots were provided in the ticket.

gaurav1984 commented 1 year ago

Additional issues reported in 6061636-zen

Issue Sensei Course and My Courses pages do not work with the Hello Elementor theme. When the theme is active on visiting any of the Sensei Pages, we get a Page Not Found message.

The pages are working properly if we switch the theme to Course or Twenty Twenty x themes

I was able to replicate the issue on my test website. The test website had the following installed.

fjorgemota commented 1 year ago

Issue reported by a user on 6905168-zd-a8c. When the "Hello Elementor" theme is active, visiting the "Course Archive Page" as set on Sensei settings causes a "Page Not Found" error to appear.

For some reason, the same issue does not happen with the "My Courses" page. Only with the "Course Archive Page" :thinking: