search

Automattic / sensei

Sensei LMS - Online Courses, Quizzes, & Learning
https://senseilms.com
GNU General Public License v2.0
542 stars 197 forks source link

LM Modern - Make sidebar sticky #5912

Open gikaragia opened 2 years ago

gikaragia commented 2 years ago

Input from this comment: p6rkRX-4Bm-p2#comment-4915

The sidebar in modern should be sticky. Also in case there aren't many lessons the sidebar should be equal to video height.

Image

yscik commented 2 years ago

I think we can add a 'Fixed/Sticky' option to the Sidebar and Header blocks in the editor, so everyone can set it based on their preference, and we can cover more cases.

The sidebar should be equal to video height

The featured-video-size.js already does the math, we can update it to output the the height as a CSS variable to use for the sidebar.

gikaragia commented 1 year ago

Reopening this as I think that PR in sensei core is still open