search

Automattic / sensei

Sensei LMS - Online Courses, Quizzes, & Learning
https://senseilms.com
GNU General Public License v2.0
539 stars 198 forks source link

3 dots are missing on Groups page on mobile #6126

Open amroland opened 1 year ago

amroland commented 1 year ago

There is no 3 dots on mobile on Groups page.

Steps to Reproduce

  1. Open your WP admin page on mobile.
  2. Go to Sensei LMS » Groups menu.
  3. You can see that there is no 3 dots at the end of the row of your groups (if you have any).

What I Expected

There should be 3 dots to use on mobile like on PC.

What Happened Instead

There are no 3 dots on mobile.

PHP / WordPress / Sensei LMS version

WordPress 6.1 PHP 7.4.26 Sensei LMS Version: 4.6.4 | Sensei Pro Version: 1.6.2

Screenshot / Video

Képernyőfotó 2022-11-16 - 12 36 47

Context / Source

mikeyarce commented 1 year ago

I'm not sure this is a bug but more a design choice on our part. If you click through to the specific group, can you perform all the actions?

My concern for showing a context menu like this on Mobile would be that it might not display properly on a small screen.

amroland commented 1 year ago

Hi @mikeyarce,

No, if you click through you can't perform all action which is included in 3 dots menu. That is a deeper submenu. You can add only members. You can't rename or delete group, for example. (I don't want to offend anyone, I'm just asking if you, in development, can't check this error on any mobile? You should see what I can see.)

And 3 dots appear on mobile on Students page, too. Although it has issue, too: https://github.com/Automattic/sensei/issues/6125

There should be a solution to use those actions on mobile, too.

mikeyarce commented 1 year ago

Hi @amroland,

You can't rename or delete group, for example.

Thanks for the info! I could definitely see that the menu was missing, I just wanted to understand better what actions couldn't be done that you were wanting to do on mobile.