search

Automattic / sensei

Sensei LMS - Online Courses, Quizzes, & Learning
https://senseilms.com
GNU General Public License v2.0
543 stars 197 forks source link

Issues with "Lesson Actions" visualisation and Divi #6488

Open aaronfc opened 1 year ago

aaronfc commented 1 year ago

Lesson actions appears two times: one completely unformatted and another with one button per line (see below screenshot)

image

~The first one is because the Video LM theme (Sensei Pro) is loading the excerpt at the top. Maybe we want to "ignore" this block content when retrieving the excerpt? Not sure though. Opinions on how to approach this one? Shall I create a ticket to look into it?~ Fixed by https://github.com/Automattic/sensei/pull/6803.

The second one is because Divi loads the existing post content by default in the content area in the editor. These is redundant, since we will have the lesson actions from LM in the correct place. Not sure the approach here. About the styling, not sure what we can do there. Should I create a ticket for this?

Originally posted by @aaronfc in https://github.com/Automattic/sensei/issues/6451#issuecomment-1411765495

aaronfc commented 1 year ago

It might be a combination of how Divi converts the initial post content (Lesson Actions is usually included in the default lesson) into the Divi-blocks based one. But it would be interesting to look a little more into it.

m1r0 commented 1 year ago

The excerpt part of this issue is fixed by https://github.com/Automattic/sensei/pull/6803.