search

Automattic / sensei

Sensei LMS - Online Courses, Quizzes, & Learning
https://senseilms.com
GNU General Public License v2.0
543 stars 197 forks source link

Header on mobile: remove stickiness #6743

Open merkushin opened 1 year ago

merkushin commented 1 year ago

On mobile we want Lesson Actions to be sticky.

As two sticky elements might take too much space, we remove stickiness for the header on mobile.

donnapep commented 1 year ago

Just wanted to doublecheck that we still want to remove the sticky header now that we decided not to make the footer sticky on mobile? What do you think @Luchadores?

merkushin commented 1 year ago

@Luchadores is AFK, I'm moving the card to Blocked until his reply.

Luchadores commented 1 year ago

Hello, I'm back 👋 I would say it depends on the theme that's being used.

Here are a few examples:

Standard Theme Both the Course Outline and the nav should be fixed/sticky. Only the content should be scrollable in this one. image

Modern I would prefer for the nav to be sticky, but here is not a must. image

Video Same as Modern, the nav doesn't have to be sticky, but it would be cool if it was. image

Large Video Same as for the Video and Modern. image

In conclusion, if we can have it sticky everywhere, that would be cool, but it's only a must for the Standard one due to the Course Outline being fixed on the left side. The rest I would let you decide based on the development effort.

Hope it helps and if there are any other questions, I'm here.