Automattic / sensei

Sensei LMS - Online Courses, Quizzes, & Learning
https://senseilms.com
GNU General Public License v2.0
540 stars 198 forks source link

Grading calculation/rounding display error #943

Closed danieldudzic closed 9 years ago

danieldudzic commented 9 years ago

There is a problem in how a quiz grade is displayed and/or calculated.

Example:

  1. We have set all our quizzes to 90% required to pass
  2. A learner (several actually) scored 89.66%, which is a FAIL
  3. On the USERS screen is says "You require 90% to pass. Your score was 90%"
  4. On the ADMIN side, in grading, it shows the actual score of 89.66%

It's clear the system is ROUNDING on the learner's display, creating confusion.

So, either the GRADING calculation need to use the same ROUNDING, or the DISPLAY needs to show the actual score, including decimal places. Not so much a bug, as an inconsistency.

Screenshots:

Link to the ticket: https://woothemes.zendesk.com/agent/tickets/303692

danjjohnson commented 9 years ago

In my opinion, we should have the grading calculation use rounding, rather than displaying decimal places.

dwainm commented 9 years ago

@danieldudzic when 1.8.5 is out the user can change this using this code:

add_filter('sensei_round_precision', 'change_round_precision');

function change_round_precision( $precision  ){
    return 2;
}

It changes the precision point with a new filter that in 1.8.5

Please wait until we release it before letting the user know.