Automattic / simplenote-android

Simplenote for Android
https://simplenote.com
GNU General Public License v2.0
1.76k stars 299 forks source link

Fix issues in Editor for Samsung devices running Android 13 #1585

Closed danilo04 closed 1 year ago

danilo04 commented 1 year ago

Fixes #1582 and #1580.

Fix

With the rollout of One UI Version 5.0 Android 13 on Samsung devices, we have observed that the Grammarly component from the Samsung keyboard messes up some Spannables. We have introduced changes to prevent the entry from being changed automatically by the keyboard.

The fix uses a wrapper of the base InputConnection that for more of the cases uses the base implementation. It handles the special case in the method commitText(...) when there are SuggestionSpan coming in the committed text. This is where we found the issues reported in #1582 and #1580 are happening.

Test

See issues #1582 and #1580 to follow the steps described in the issues.

Review

Only one developer is required to review these changes, but anyone can perform the review.

Release

RELEASE-NOTES.txt was updated in edd69acbea02eb3c02a47b37d25be2a95fa4534d with:

Fixed problem with editor in Samsung devices with Android 13.

wpmobilebot commented 1 year ago
You can test the changes on this Pull Request by downloading an installable build (simplenote-android-installable-build-pr1585-edd69ac-0186bc5b-2989-476f-b6c6-4fe8d4ac619e.apk), or scanning this QR code:
azollafox commented 1 year ago

I've seen 2 reports of issues for Samsung users that sound similar to me in our app reviews today

There are issues with my phone, SAMSUNG S21. There is alot of duplicating of lines even after v2.27

azollafox commented 1 year ago

Recently on my Samsung device, Simplenote has started duplicating my input as I type. Is there an update?

https://link.reviewbot.io/notification?action=reply&review=pfIfKxL5QcMDJN6mFg7I

azollafox commented 1 year ago

Never mind, I suspect this is all due to the server issues we have

azollafox commented 9 months ago

Simplenote app ver 2.30 on Android ver 13 on Samsung Galaxy S20 5G

When editing long note, once the keyboard appear, the text display will default to last line of note when pausing on typing.

For example, I have a note that has 100 lines showing on the Galaxy S20 phone screen.

I want to edit text on line #3, so I put the cursor is on line 3 and start typing. When I pause typing my text on line #3, the display text is auto- scrolling down to last line of the note. So I can not read what I just type on line #3, unless I have to scroll back from from the last line #100 up to line #3.

Is this a known bug issue that Simplenote are working on solving?

https://forums.simplenote.com/forums/topic/auto-scrolling-down-to-last-line-of-the-note/?view=all#post-1404