Automattic / simplenote-android

Simplenote for Android
https://simplenote.com
GNU General Public License v2.0
1.76k stars 299 forks source link

Use the default implementation for getExtractedText #1591

Closed danilo04 closed 1 year ago

danilo04 commented 1 year ago

Fixes #1590.

Fix

Users using Samsung devices with Android 13 are experiencing text duplication.

Test

Note: Please test on a Samsung device with Android 13.

  1. Create a new note
  2. Type Hello 2.22. In the current version, the editor duplicates the version and adds Hello. 2.22.2.
  3. Check steps in issue #1590 and verify that the problem is fixed.
  4. Check steps in issue #1582 and verify that the problem is fixed.
  5. Check steps in issue #1580 and verify that the problem is fixed.

Review

Only one developer is required to review these changes, but anyone can perform the review.

Release

RELEASE-NOTES.txt was updated in 70f15503a129c11904b407258374ee4aa6ad6107 with:

Fixed problem with editor in Samsung devices where users observed text duplication.

wpmobilebot commented 1 year ago
You can test the changes on this Pull Request by downloading an installable build (simplenote-android-installable-build-pr1591-70f1550-01874db4-e714-4e29-82cb-625cc5ccc536.apk), or scanning this QR code:
khaykov commented 1 year ago

Good news - issues is definitely happens less.

Bad news it still happens if some parts of the text were "flagged" by Grammarly for correction.

https://user-images.githubusercontent.com/728822/229919572-ab1225e3-6b64-4e7d-a1a1-503f167dc5e6.mp4