Automattic / simplenote-android

Simplenote for Android
https://simplenote.com
GNU General Public License v2.0
1.76k stars 299 forks source link

Merge 2.28 final to trunk #1604

Closed oguzkocer closed 1 year ago

oguzkocer commented 1 year ago

Since Simplenote-Android is not an active project, I skipped the usual code freeze cycle and immediately finalized the release. I considered giving translators some time for the release notes, but there is nothing particularly important in them, so I thought it made sense to put this out as soon as possible.

The project is quite outdated and I had to make some changes to get it to work:

In 3fc25645d58c29748b4261ada87a6b894622516a I updated the ndkVersion. The previous ndkVersion wasn't available in my machine and it was not available to install. I picked one of the latest versions that was already available in my machine. I'm hoping this won't cause any extra issues for us.

I had a lot of trouble with conflicting information in .configure, Simplenote/gradle.properties & Fastfile. For example, in this PR google-upload-credentials.json & the debug keystore was put outside the project folder, but then when the configure Gradle plugin was added in this PR, the path was changed, but not reflected in fastlane. For now, I updated the path in 2aaf79940fbd7a848e2df5cadec84d29f3f18ae1 to point to where the file is currently being extracted.

Similarly, the storeFile & debugStoreFile in Simplenote/gradle.properties were pointing to a different path than where they are actually extracted to. I've updated this in .mobile-secrets, however I couldn't get ./gradlew updateConfiguration to work, so for this release I manually updated my local file. The problem seems to be related to libssl which should be fixed in the latest configure plugin release, but I think it's not playing well with the old Gradle version. I spent some time on it, but then gave up for now.