search

Automattic / simplenote-android

Simplenote for Android
https://simplenote.com
GNU General Public License v2.0
1.75k stars 299 forks source link

Upgrade Simperium dependency and upgrade to SDK 33 #1612

Closed danilo04 closed 9 months ago

danilo04 commented 9 months ago

Fix

Fixes #1611.

Simperium PR: https://github.com/Simperium/simperium-android/pull/248.

On Simplenote, we get crashes when a note is big and exceeds the SQLite row size (2 MB). We are going to catch SQLException and return a missing object for the cases in which we get an exception.

Test

Smoke test the whole app:

  1. Test login
  2. Test adding a new note and check that the note is synced and available in other devices (you can try the web app https://app.simplenote.com/)
  3. Test adding notes from the web app and check that they are visible on the Android device.
  4. Try adding tasks lists and checking their boxes. Check that the updates are seen in other devices.
  5. Try adding a collaborator and check that the user you share the note to receives an email.
  6. Try adding note references in your note. Type [title of note] to see if you get a list of possible notes to link.
  7. Try adding, editing and deleting tags.
  8. Try searching for notes.
  9. Try changing the theme.
  10. Try changing the font size and see that the note list and the notes font size (in the editor) use the font size set.
  11. Try setting up a lock screen in Settings. Leave the app and then enter it again using the code you setup.
  12. Try publishing a note. Go to a note and tap on the top-right menu and tap.
  13. Try to reverse a note to an earlier revision. Tap on the top-right menu and then tap on History. Change the slider to different versions and see how the note changes. Select one version and see that the note is updated to that version on other devices.

Review

Only one developer is required to review these changes, but anyone can perform the review.

Release

RELEASE-NOTES.txt was updated in 21e349f0206bcd9984719aeddd14f6f585d0530f with:

Fixed crashes when a big note is tried to be synced.

wpmobilebot commented 9 months ago
You can test the changes on this Pull Request by downloading an installable build (simplenote-android-installable-build-pr1612-aea8330-018b1b02-2bd8-4998-87f3-03cc51bdb8a9.apk), or scanning this QR code: