search

Automattic / simplenote-android

Simplenote for Android
https://simplenote.com
GNU General Public License v2.0
1.75k stars 299 forks source link

Add themed icon #1615

Closed 2zqa closed 5 months ago

2zqa commented 8 months ago

Fix

Added support for themed icons that were introduced with Android 13. This ensures the app looks consistent with other themed apps on setups that use Android 13 with the themed app icons enabled.

Dark mode screenshot Light mode screenshot

Closes #1565

Test

  1. Use Android 13 or newer[^1] (tested on Pixel 3a with API level 34, extension level 7 x86_64 emulator)
  2. Enable themed icons: press and hold on an empty space on the homescreen, go to wallpaper and style, and ensure themed icons are enabled
  3. Go back to the homescreen
  4. Observe that the icon is like in the screenshots above

Review

Only one developer and one designer are required to review these changes, but anyone can perform the review.

Release

Added themed app icon

[^1]: I couldn't get the app running without running the AGP Upgrade Assistant (probably because my Android SDK was too new). This might impact the reproducibility of the testing, so please do verify whether it works without this intervention.

roundhill commented 5 months ago

Heyyy @2zqa! Thanks for the PR and sorry for the huge delay there. I'll review this week.

2zqa commented 5 months ago

Awesome, thanks for merging! This was the last icon on my page without a themed icon. About the padding: perhaps so. I wasn't aware of any branding guidelines so I didn't want to change anything right off the bat. I'll see if I can check with Androids icon template if I can align it.