WIP – Update release-toolkit and code using it

Automattic / simplenote-android

Simplenote for Android

https://simplenote.com

GNU General Public License v2.0

1.77k stars 300 forks source link

WIP – Update release-toolkit and code using it #1640

Closed mokagio closed 1 month ago

mokagio commented 6 months ago

This is in the attempt to solve a runtime crash where the plugin fails because build_gradle_path is not provided.

The crash was likely introduced when upgrading from 9.1.0 to 9.4.0, in 65d742c.

Fix

Test

Review

Release

dangermattic commented 6 months ago

	1 Message
:book:	This PR is still a Draft: some checks will be skipped.

Generated by :no_entry_sign: Danger

wpmobilebot commented 6 months ago

📲 You can test the changes from this Pull Request in Simplenote Android by scanning the QR code below to install the corresponding build.

	App Name	Simplenote Android
	Build Type	Debug
	Commit	968067c15710f87d1f3d665e531b750b4085c508
	Direct Download	`simplenote-android-prototype-build-pr1640-968067c-018e12eb-6d9b-4eb6-9c23-9dbcec058d9b.apk`

AliSoftware commented 1 month ago

@mokagio is this PR still relevant or should we now close it? (I see it dates back from March)

mokagio commented 1 month ago

Thanks for the ping @AliSoftware .

This PR is no longer relevant. It was an attempt to update release-toolkit as part of a Simplenote release, but in working through it I kept running into build_gradle_path-related issues. This led to realizing that parameter and versioning approach to be obsolete.

The work in #1676 supersedes this by updating the versioning strategy, among other things, and testing a pre-release release-toolkit that no longer support build_gradle_path.