Remove sustainer UI - Githubissues

Automattic / simplenote-android

Simplenote for Android

https://simplenote.com

GNU General Public License v2.0

1.75k stars 299 forks source link

Remove sustainer UI #1644

Closed roundhill closed 3 months ago

roundhill commented 3 months ago

This PR removes the sustainer UI and related in-app-purchase code. I've opted to just remove everything, but if we think we might want to use the banners for something else in the future we could keep them around instead...

Test

Launch the app, logged out.
Sign in to an account with or without sustainer associated with it.
Open the drawer, you should not see the sustainer banner.
Open settings, you should not see the sustainer banner.
Verify other views in the app work as expected.

Release

These changes do not require release notes.

dangermattic commented 3 months ago

	3 Warnings
:warning:	`strings.xml` files should only be updated on release branches, when the translations are downloaded by our automation.
:warning:	This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
:warning:	PR is not assigned to a milestone.

Generated by :no_entry_sign: Danger

wpmobilebot commented 3 months ago

📲 You can test the changes from this Pull Request in Simplenote Android by scanning the QR code below to install the corresponding build.

	App Name	Simplenote Android
	Build Type	Debug
	Commit	4cd8467e8908587e0a4fbc933e3e0b481531e0d5
	Direct Download	`simplenote-android-prototype-build-pr1644-4cd8467-018ebe3e-e457-45ad-8934-233d9cc2776d.apk`

roundhill commented 3 months ago

Do we want to also remove billing dependency (com.android.billingclient:billing:6.0.1) ?

Yes, removed in https://github.com/Automattic/simplenote-android/pull/1644/commits/4cd8467e8908587e0a4fbc933e3e0b481531e0d5

Thank you @khaykov!