Automattic / simplenote-android

Simplenote for Android
https://simplenote.com
GNU General Public License v2.0
1.75k stars 299 forks source link

(WIP) Fix note editor jumping to bottom #1656

Closed roundhill closed 2 months ago

roundhill commented 2 months ago

Fix

Should fix #1580 - Saving the y offset of the note editor and restoring it appears to be the cause of the bug. Opening this PR to test a build from. My theory is that on some devices, when the view needs to be adjusted for the soft keyboard, the OS will scroll the view into view and we were also scrolling the view ourselves which would push it to the bottom.

Test

  1. Open a long note
  2. Tap in the middle of the note and make some changes
  3. The editor scroll position should never change
  4. Test making a change on another device to the same note, the editor scroll should stay put
  5. Test that search results in a note still scroll into view when you tap the arrows
wpmobilebot commented 2 months ago

📲 You can test the changes from this Pull Request in Simplenote Android by scanning the QR code below to install the corresponding build.

App Name Simplenote Android
Build TypeDebug
Commit533baf071302b08120aa5e8a5bd7100c9df0e2d6
Direct Downloadsimplenote-android-prototype-build-pr1656-533baf0-018f78fd-fb17-462b-946c-e71fffd3f914.apk