Automattic / simplenote-android

Simplenote for Android
https://simplenote.com
GNU General Public License v2.0
1.78k stars 301 forks source link

[Lib] Update kotlin and cascading errors that came up as a result. #1664

Closed notandyvee closed 3 months ago

notandyvee commented 3 months ago

Fix

When attempting to import the androidx credential manager library, gradle would fail. This was due to having an old kotlin version. This started the journey to update kotlin (1.9.22). This update required a few resulting library errors which I needed to update. The big one was Simperium, which caused a crash on startup.

The goal in this PR is simply to update some core libraries. No changes should be expected... ideally 😅 .

Test

Review

@danilo04

Release

These changes do not require release notes.

wpmobilebot commented 3 months ago

📲 You can test the changes from this Pull Request in Simplenote Android by scanning the QR code below to install the corresponding build.

App Name Simplenote Android
Build TypeDebug
Commit8f4da871b8fa95928bb0adf8b55f8add6a57c27d
Direct Downloadsimplenote-android-prototype-build-pr1664-8f4da87-0190a7e3-1868-4f00-9a3a-ea485e17df3c.apk
notandyvee commented 3 months ago

Head up @danilo04 , to avoid any issues if we make a release sooner for magic links, I am merging this into the passkey feature branch (andy/passkey-feature). Once everything is merged, I will make a final large PR into trunk after each individual smaller PR has been reviewed. That cool?

danilo04 commented 3 months ago

Yeah, that is OK.