Closed notandyvee closed 1 month ago
1 Warning | |
---|---|
:warning: | Class MagicLinkAuthError is missing tests, but unit-tests-exemption label was set to ignore this. |
Generated by :no_entry_sign: Danger
📲 You can test the changes from this Pull Request in Simplenote Android by scanning the QR code below to install the corresponding build.
App Name | Simplenote Android | |
Build Type | Debug | |
Commit | f3c21e5910c6e9662cc4fcf0f2f7359e9833bf57 | |
Direct Download | simplenote-android-prototype-build-pr1672-f3c21e5-01910b22-b048-4e3c-a4e2-4b3d8eac4545.apk |
Most of the apps I've seen around, at most, have a button somewhere that says something like... Send new code in x seconds
, and it only becomes clickable once the code actually expired.
We could try something like that perhaps? (as v2?)
Fix
During the magic link code confirmation and the server returns a 400 with
invalid-code
, we want to go back one screen. Basically so the user can request another magic link.Test
Review
Note: The invalid code has to be a previously valid one I think.
Release
n/a