[Auth] Added Accept-Language header for localizing magic link email.

Automattic / simplenote-android

Simplenote for Android

https://simplenote.com

GNU General Public License v2.0

1.79k stars 301 forks source link

[Auth] Added Accept-Language header for localizing magic link email. #1675

Closed notandyvee closed 3 months ago

notandyvee commented 3 months ago

Fix

Adds Accept-Language header when requesting magic link.

Test

[ ] You need to have your device spoof a specific locale. es_ES or de_DE.
[ ] The magic link email should be in a language other than english.

Release

n/a

dangermattic commented 3 months ago

	1 Warning
:warning:	Class `HeadersInterceptor` is missing tests, but `unit-tests-exemption` label was set to ignore this.

Generated by :no_entry_sign: Danger

notandyvee commented 3 months ago

Do you think it's necessary to add it to every request?

Necessary. No. I could move it back to the single place if we care. It's not a lot of extra characters, and lays the foundation to add more necessary headers.

wpmobilebot commented 3 months ago

📲 You can test the changes from this Pull Request in Simplenote Android by scanning the QR code below to install the corresponding build.

	App Name	Simplenote Android
	Build Type	Debug
	Commit	31232149360e8102ac4106d52ac83eadbc625040
	Direct Download	`simplenote-android-prototype-build-pr1675-3123214-01914d9a-388a-4b1d-9470-5ecdeb04dace.apk`