Upgrade `release-toolkit`

Automattic / simplenote-android

Simplenote for Android

https://simplenote.com

GNU General Public License v2.0

1.78k stars 301 forks source link

Upgrade `release-toolkit` #1676

Closed mokagio closed 2 months ago

mokagio commented 2 months ago

Fix

Test

Review

Release

wpmobilebot commented 2 months ago

📲 You can test the changes from this Pull Request in Simplenote Android by scanning the QR code below to install the corresponding build.

	App Name	Simplenote Android
	Build Type	Debug
	Commit	3ee5a854c5c0e46edac7932282b398600bf8b356
	Direct Download	`simplenote-android-prototype-build-pr1676-3ee5a85-019154e5-8edc-4d04-bcb0-667e4847db52.apk`

AliSoftware commented 2 months ago

FYI I've just opened https://github.com/Automattic/simplenote-android/pull/1677 to fix CVE on rexml… which might conflict with your draft PR here

AliSoftware commented 2 months ago

Note that while #1677 fixed the rexml-related CVEs, there's currently one remaining CVE about nokogiri still open.

Fixing it will require to update release-toolkit to a newer version, as nokogiri is a dependency of it and that's where the version constraint on it comes from. Since the update of release-toolkit is already planned to be handled by this very PR, I'm leaving it to @mokagio and this PR to fix that last CVE as a side-effect of updating release-toolkit.

mokagio commented 2 months ago

Closed in favor of #1680