Closed notandyvee closed 2 months ago
7 Warnings | |
---|---|
:warning: | strings.xml files should only be updated on release branches, when the translations are downloaded by our automation. |
:warning: | This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews. |
:warning: | Class AbstractAppLock is missing tests, but unit-tests-exemption label was set to ignore this. |
:warning: | Class AppLockManager is missing tests, but unit-tests-exemption label was set to ignore this. |
:warning: | Class DefaultAppLock is missing tests, but unit-tests-exemption label was set to ignore this. |
:warning: | Class PasscodePreferenceFragmentCompat is missing tests, but unit-tests-exemption label was set to ignore this. |
:warning: | Class StringUtils is missing tests, but unit-tests-exemption label was set to ignore this. |
Generated by :no_entry_sign: Danger
📲 You can test the changes from this Pull Request in Simplenote Android by scanning the QR code below to install the corresponding build.
App Name | Simplenote Android | |
Build Type | Debug | |
Commit | 9a3c062fb7a6a1dee5f03981231382be35d09c08 | |
Direct Download | simplenote-android-prototype-build-pr1678-9a3c062-01914d64-5541-4867-8a1b-a725cc10d614.apk |
Fix
Last week we started to have build issues as a result jcenter being deprecated. The offending library was passcodelock. The library is no longer being maintained and it appears Simplenote is the only app using it internally.
I attempted to import the library module directly from the original project. But I couldn't get it to build. The library structure isn't even proper as far as I can tell. Not sure how it ever built. Rather than waste anymore cycles, I simply created a new module in this repo called
PasscodeLock
, and copy pasta'd all the relevant bits. After fixing build issues I got it working.Test
Review
Note that this was a straight copy pasta. The lib hasn't changed in 5 years or so. You are free to point out any UI inconsistencies or bugs, but I think the logic itself should be out of scope.
Release
N/A